fix(completions): replace error node handling with better grammar #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base-community/postgres_lsp into feat/completions-test-suite
…_lsp into feat/completions-test-suite
…base-community/postgres_lsp into fix/completion-issues
…_lsp into fix/completion-issues
psteinroe
approved these changes
Dec 15, 2025
Collaborator
psteinroe
left a comment
psteinroe
left a comment
There was a problem hiding this comment.
its so nice how the code now is much more about scoring and less about parsing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error node handling was necessary because the grammar was too rigid for our purposes.
For completions/hover, it makes sense to have a heavily "left-balanced" grammar—whenever a statement type is recognizable by its one, two, three etc. first tokens, it should be recognized as that statement type.
Example:
alter table auth.users |should be recognized as an alter table statement, it shouldn't require a trailingalter column …ordrop column …and so on.